Skip to content

CI: ASV Bot #41157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lithomas1 opened this issue Apr 26, 2021 · 1 comment · Fixed by #42911
Closed

CI: ASV Bot #41157

lithomas1 opened this issue Apr 26, 2021 · 1 comment · Fixed by #42911
Assignees
Labels
Benchmark Performance (ASV) benchmarks CI Continuous Integration Enhancement
Milestone

Comments

@lithomas1
Copy link
Member

lithomas1 commented Apr 26, 2021

Is your feature request related to a problem?

Running ASV's takes a really long time, especially with old computers, and the ASVs in PRs are not run in continuous mode, which makes it hard to find regressions before a PR is merged.

asv dev | sed "/failed$/ s/^/##[error]/" | tee benchmarks.log

(master, what we run currently, asv dev)

Describe the solution you'd like

A github actions workflow that runs asv continuous -f 1.1 upstream/master HEAD on PRs after seeing a comment such as @github-actions asv. In order to prevent false positives, I think the bot should first merge in master to a PR before running benchmarks.

autotune:
name: "Fixup pre-commit formatting"
if: startsWith(github.event.comment.body, '@github-actions pre-commit')

(example for triggering)

Afterwards, the bot should comment the results. (I'm not sure how to do this)

I don't think it should be a check, since it takes a while to run and might be flaky. Making it a check would run it on every commit in a PR which would make CI queue times longer for everyone.

Additional context

#36860 https://pandas.pydata.org/docs/development/roadmap.html#performance-monitoring

@lithomas1 lithomas1 added Enhancement CI Continuous Integration Needs Triage Issue that has not been reviewed by a pandas team member labels Apr 26, 2021
@mzeitlin11 mzeitlin11 removed the Needs Triage Issue that has not been reviewed by a pandas team member label Jul 1, 2021
@mzeitlin11 mzeitlin11 added this to the Contributions Welcome milestone Jul 1, 2021
@lithomas1 lithomas1 added the Benchmark Performance (ASV) benchmarks label Aug 3, 2021
@lithomas1 lithomas1 self-assigned this Aug 3, 2021
@lithomas1 lithomas1 mentioned this issue Aug 6, 2021
4 tasks
@jreback jreback modified the milestones: Contributions Welcome, 1.4 Aug 8, 2021
@jreback
Copy link
Contributor

jreback commented Sep 4, 2021

feel free to make a followon issue here to support args to the bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Performance (ASV) benchmarks CI Continuous Integration Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants