Skip to content

DOC: Fixed GL02 errors in documentation #42809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2021
Merged

Conversation

fshi01
Copy link
Contributor

@fshi01 fshi01 commented Jul 30, 2021

Fixed 2 of the 4 GL02 errors generated by pandas_validation_errors.ipynb
The remaining two errors are from pandas.Timestamp.isoweekday and will be tackled next.

@jbrockmendel
Copy link
Member

is there a linter check we're going to add for this?

@mroeschke
Copy link
Member

xref #25120

@mroeschke mroeschke merged commit 69a1155 into pandas-dev:master Aug 6, 2021
@mroeschke
Copy link
Member

Thanks @fshi01. Happy to have you to tackle the remaining GL02 errors and add a check in our CI.

@fshi01
Copy link
Contributor Author

fshi01 commented Aug 11, 2021

In addition to the remaining GL02 errors and adding a check to the CI, is there anything else I should do before it is merged?

@mroeschke
Copy link
Member

Nothing in particular.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants