Skip to content

REGR: nanosecond timestamp comparisons to OOB datetimes #42796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 29, 2021
Merged

REGR: nanosecond timestamp comparisons to OOB datetimes #42796

merged 3 commits into from
Jul 29, 2021

Conversation

mzeitlin11
Copy link
Member

@mzeitlin11 mzeitlin11 changed the title Regr timestamps oob REGR: nanosecond timestamp comparisons to OOB datetimes Jul 29, 2021
@mzeitlin11 mzeitlin11 added Numeric Operations Arithmetic, Comparison, and Logical operations Regression Functionality that used to work in a prior pandas version Datetime Datetime data dtype labels Jul 29, 2021
@mzeitlin11 mzeitlin11 added this to the 1.3.2 milestone Jul 29, 2021
jbrockmendel
jbrockmendel approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreback jreback merged commit a4c5d78 into pandas-dev:master Jul 29, 2021
@jreback
Copy link
Contributor

jreback commented Jul 29, 2021

thanks @mzeitlin11

@jreback
Copy link
Contributor

jreback commented Jul 29, 2021

@meeseeksdev backport 1.3.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jul 29, 2021
@mzeitlin11 @meeseeksmachine
Backport PR pandas-dev#42796: REGR: nanosecond timestamp comparisons …
46ce6ae 
…to OOB datetimes
@meeseeksmachine meeseeksmachine mentioned this pull request Jul 29, 2021
Merged
@lumberbot-app
Copy link

lumberbot-app bot commented Jul 29, 2021

Something went wrong ... Please have a look at my logs.

@mzeitlin11 mzeitlin11 deleted the regr_timestamps_oob branch July 29, 2021 23:27
jreback pushed a commit that referenced this pull request Jul 30, 2021
@meeseeksmachine @mzeitlin11
Backport PR #42796: REGR: nanosecond timestamp comparisons to OOB dat…
5df103c 
…etimes (#42806)

Co-authored-by: Matthew Zeitlin <[email protected]>
Leonardofreua pushed a commit to Leonardofreua/pandas that referenced this pull request Jul 30, 2021
@mzeitlin11 @Leonardofreua
REGR: nanosecond timestamp comparisons to OOB datetimes (pandas-dev#4…
ebaa9c1 
…2796)
attack68 added a commit that referenced this pull request Jul 31, 2021
@Leonardofreua @rhshadrach
@Dr-Irv @smithto1 @jbrockmendel @attack68 @mzeitlin11 @lithomas1 @phofl @jreback @KrishnaSai2020
TST: Fix doctests in style.py (#42783)
7963422 
* TST: Fix doctests for pandas.io.formats.style

* Modified: pandas/io/formats/style.py

* Added some expected results

* Skipped some tests

* TST: Add link to redirect to Table Visualization user guide

* Modified style.py

* Updated the doctest of the apply()

* Updated the doctest of the applymap()

* Updated the doctest of the set_table_styles()

* Updated the doctest of the set_properties()

* TST: Add image to pipe function result

* Modified style.py

* Updated the doctest of the pipe()

* TST: Remove unnecessary outputs

* Modified pandas/io/formats/style.py

* Updated the doctests of the set_tooltips()

* Updated the doctests of the to_latex()

* Updated the doctests of the set_td_classes()

* Updated the doctests of the set_table_attributes()

* TST: Add the output to the Styler.format doctest in to_latex()

* REG: DataFrame.agg where func returns lists and axis=1 (#42762)

* Fix typing issues for CI (#42770)

* BUG: groupby.shift returns different columns when fill_value is specified (#41858)

* PERF: extract_array earlier in DataFrame construction (#42774)

* ENH: `sparse_columns` and `sparse_index` added to `Styler.to_html`  (#41946)

* TYP: Fix typing for searchsorted (#42788)

* DOC GH42756 Update documentation for pandas.DataFrame.drop to clarify tuples. (#42789)

* CI: Fix doctests (#42790)

* REGR: nanosecond timestamp comparisons to OOB datetimes (#42796)

* COMPAT: MPL 3.4.0 (#42803)

* Delete duplicates and unused code from reshape tests (#42802)

* REGR: ValueError raised when both prefix and names are set to None (#42690)

* REGR: ValueError raised when both prefix and names are set to None

* Update readers.py

* whitespace

* Update v1.3.1.rst

* Update v1.3.2.rst

* Update readers.py

* Update readers.py

Co-authored-by: Jeff Reback <[email protected]>

* TST: Add style.py to the doctest check

* TST: fixed eng_formatter doctest for #42671 (#42705)

* TST: Revert x and y position in some doctests

* Updated the doctest of the hide_columns()

Co-authored-by: Richard Shadrach <[email protected]>
Co-authored-by: Irv Lustig <[email protected]>
Co-authored-by: Thomas Smith <[email protected]>
Co-authored-by: jbrockmendel <[email protected]>
Co-authored-by: attack68 <[email protected]>
Co-authored-by: Mike Phung <[email protected]>
Co-authored-by: Matthew Zeitlin <[email protected]>
Co-authored-by: Thomas Li <[email protected]>
Co-authored-by: Patrick Hoefler <[email protected]>
Co-authored-by: Jeff Reback <[email protected]>
Co-authored-by: Krishna Chivukula <[email protected]>
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@mzeitlin11 @feefladder
REGR: nanosecond timestamp comparisons to OOB datetimes (pandas-dev#4…
188eafc 
…2796)
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@Leonardofreua @rhshadrach
@Dr-Irv @smithto1 @jbrockmendel @attack68 @mzeitlin11 @lithomas1 @phofl @jreback @KrishnaSai2020 @feefladder
TST: Fix doctests in style.py (pandas-dev#42783)
d3e661f 
* TST: Fix doctests for pandas.io.formats.style

* Modified: pandas/io/formats/style.py

* Added some expected results

* Skipped some tests

* TST: Add link to redirect to Table Visualization user guide

* Modified style.py

* Updated the doctest of the apply()

* Updated the doctest of the applymap()

* Updated the doctest of the set_table_styles()

* Updated the doctest of the set_properties()

* TST: Add image to pipe function result

* Modified style.py

* Updated the doctest of the pipe()

* TST: Remove unnecessary outputs

* Modified pandas/io/formats/style.py

* Updated the doctests of the set_tooltips()

* Updated the doctests of the to_latex()

* Updated the doctests of the set_td_classes()

* Updated the doctests of the set_table_attributes()

* TST: Add the output to the Styler.format doctest in to_latex()

* REG: DataFrame.agg where func returns lists and axis=1 (pandas-dev#42762)

* Fix typing issues for CI (pandas-dev#42770)

* BUG: groupby.shift returns different columns when fill_value is specified (pandas-dev#41858)

* PERF: extract_array earlier in DataFrame construction (pandas-dev#42774)

* ENH: `sparse_columns` and `sparse_index` added to `Styler.to_html`  (pandas-dev#41946)

* TYP: Fix typing for searchsorted (pandas-dev#42788)

* DOC GH42756 Update documentation for pandas.DataFrame.drop to clarify tuples. (pandas-dev#42789)

* CI: Fix doctests (pandas-dev#42790)

* REGR: nanosecond timestamp comparisons to OOB datetimes (pandas-dev#42796)

* COMPAT: MPL 3.4.0 (pandas-dev#42803)

* Delete duplicates and unused code from reshape tests (pandas-dev#42802)

* REGR: ValueError raised when both prefix and names are set to None (pandas-dev#42690)

* REGR: ValueError raised when both prefix and names are set to None

* Update readers.py

* whitespace

* Update v1.3.1.rst

* Update v1.3.2.rst

* Update readers.py

* Update readers.py

Co-authored-by: Jeff Reback <[email protected]>

* TST: Add style.py to the doctest check

* TST: fixed eng_formatter doctest for pandas-dev#42671 (pandas-dev#42705)

* TST: Revert x and y position in some doctests

* Updated the doctest of the hide_columns()

Co-authored-by: Richard Shadrach <[email protected]>
Co-authored-by: Irv Lustig <[email protected]>
Co-authored-by: Thomas Smith <[email protected]>
Co-authored-by: jbrockmendel <[email protected]>
Co-authored-by: attack68 <[email protected]>
Co-authored-by: Mike Phung <[email protected]>
Co-authored-by: Matthew Zeitlin <[email protected]>
Co-authored-by: Thomas Li <[email protected]>
Co-authored-by: Patrick Hoefler <[email protected]>
Co-authored-by: Jeff Reback <[email protected]>
Co-authored-by: Krishna Chivukula <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

Assignees
No one assigned
Labels
Datetime Datetime data dtype Numeric Operations Arithmetic, Comparison, and Logical operations Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.3.2
Development

Successfully merging this pull request may close these issues.

BUG: Series.clip() behaviour is wrong with Series[datetime] comparison to pd.Timestamp.{min,max}
3 participants
@mzeitlin11 @jreback @jbrockmendel