-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC use pepy-tech badge in README instead of conda-forge one #42710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are different things. anaconda.org downloads are distinct from PyPI, which pepy is counting. Perhaps they should be there any labeled PyPI download and the other Anaconda.org Downloads.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah the reason for suggesting this is that, if pandas is going to show downloads, it's probably better to show the PyPI ones, as the conda-forge ones are only a small fraction (about 2%)
not sure if there's a way to change the label, will check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could put both badges here. Maybe change the name to
Conda DownloadsandPyPI Downloads.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah can we add both badges? (and change names)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've edited this badge to read "PyPI downloads per month"
I don't see how to edit the conda-forge one (https://anaconda.org/conda-forge/pandas/badges), and IMO showing "PyPI downloads per month: 62M" and "Total downloads: 18M" next to each other wouldn't inspire much confidence in a data analysis library 😄
So, my suggestion is to not how the conda downloads until we can customize its text (though if someone finds to do that already, please do let me know!)