Skip to content

DOC use pepy-tech badge in README instead of conda-forge one #42710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2021

Conversation

MarcoGorelli
Copy link
Member

cf Gitter conversation

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

README.md Outdated
@@ -12,7 +12,7 @@
[![License](https://img.shields.io/pypi/l/pandas.svg)](https://github.com/pandas-dev/pandas/blob/master/LICENSE)
[![Azure Build Status](https://dev.azure.com/pandas-dev/pandas/_apis/build/status/pandas-dev.pandas?branch=master)](https://dev.azure.com/pandas-dev/pandas/_build/latest?definitionId=1&branch=master)
[![Coverage](https://codecov.io/github/pandas-dev/pandas/coverage.svg?branch=master)](https://codecov.io/gh/pandas-dev/pandas)
[![Downloads](https://anaconda.org/conda-forge/pandas/badges/downloads.svg)](https://pandas.pydata.org)
[![Downloads](https://pepy.tech/badge/pandas/month)](https://pepy.tech/project/pandas)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are different things. anaconda.org downloads are distinct from PyPI, which pepy is counting. Perhaps they should be there any labeled PyPI download and the other Anaconda.org Downloads.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah the reason for suggesting this is that, if pandas is going to show downloads, it's probably better to show the PyPI ones, as the conda-forge ones are only a small fraction (about 2%)

not sure if there's a way to change the label, will check

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could put both badges here. Maybe change the name to Conda Downloads and PyPI Downloads.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah can we add both badges? (and change names)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've edited this badge to read "PyPI downloads per month"

I don't see how to edit the conda-forge one (https://anaconda.org/conda-forge/pandas/badges), and IMO showing "PyPI downloads per month: 62M" and "Total downloads: 18M" next to each other wouldn't inspire much confidence in a data analysis library 😄

So, my suggestion is to not how the conda downloads until we can customize its text (though if someone finds to do that already, please do let me know!)

@jreback jreback added the Docs label Jul 26, 2021
@jreback jreback added this to the 1.4 milestone Jul 26, 2021
@MarcoGorelli MarcoGorelli marked this pull request as draft August 31, 2021 08:51
@jreback
Copy link
Contributor

jreback commented Aug 31, 2021

@MarcoGorelli status of this?

@MarcoGorelli
Copy link
Member Author

@MarcoGorelli status of this?

I've edited this badge to read "PyPI downloads per month"

I don't see how to edit the conda-forge one (https://anaconda.org/conda-forge/pandas/badges)

So, my suggestion is to just remove the conda downloads count, unless someone can suggest a way to customize its badge's text

@MarcoGorelli MarcoGorelli marked this pull request as ready for review September 12, 2021 16:55
@jreback jreback merged commit 464416d into master Sep 12, 2021
@jreback
Copy link
Contributor

jreback commented Sep 12, 2021

sure

@MarcoGorelli MarcoGorelli deleted the pepy-tech-badge branch September 12, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants