TYP: Update input of core.algorithms.duplicated
#42657
Conversation
lilisako
commented
Jul 22, 2021
•
lilisako
commented
- closes TYP: Improve typing on pandas.core.algorithms.duplicated() #42604
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
lilisako
changed the title
core.algorithms.duplicatedcore.algorithms.duplicated
pandas/core/algorithms.py
Outdated
| @@ -903,7 +904,8 @@ def value_counts_arraylike(values, dropna: bool): | |||
|
|
|||
|
|
|||
| def duplicated( | |||
| values: ArrayLike, keep: Literal["first", "last", False] = "first" | |||
| values: np.ndarray | ExtensionArray | Series, | |||
There was a problem hiding this comment.
ArrayLike is a alias for np.ndarray | ExtensionArray and can union aliases with other types
| values: np.ndarray | ExtensionArray | Series, | |
| values: ArrayLike | Series, |
AnyArrayLike also includes Index (as well as Series). Is an Index not a valid type here?
There was a problem hiding this comment.
@simonjayhawkins
Thanks for the review!
AnyArrayLike also includes Index (as well as Series). Is an Index not a valid type here?
I checked index type and it seems duplicated function accepts one.
import pandas as pd
from pandas.core.algorithms import duplicated
index = pd.Index([1,2,3,4,2,3,1])
duplicated(index)
>> array([False, False, False, False, True, True, True])
Maybe it will be like this?
| values: np.ndarray | ExtensionArray | Series, | |
| values: AnyArrayLike, |
There was a problem hiding this comment.
Great. can you also update the parameters section of the docsting.
There was a problem hiding this comment.
Yes! I have pushed the code with those change as well!
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
Thanks for the pull request, but although its still a draft, it has appeared to have gone stale. If you're still interested in working on this let us know and we can reopen. |
