Skip to content

TYP: Improve typing on pandas.core.algorithms.duplicated() #42604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Dr-Irv opened this issue Jul 19, 2021 · 0 comments
Open

TYP: Improve typing on pandas.core.algorithms.duplicated() #42604

Dr-Irv opened this issue Jul 19, 2021 · 0 comments
Labels
duplicated duplicated, drop_duplicates Typing type annotations, mypy/pyright type checking

Comments

@Dr-Irv
Copy link
Contributor

Dr-Irv commented Jul 19, 2021

Per comment in PR #41985 :
https://github.com/pandas-dev/pandas/pull/41985/files/c14bca375fc1f88b0ebc3fdf9d94bab568d1066a#r672213029

PR updated the docs, which reflected that pandas.core.algorithms.duplicated() does accept a Series as an argument:

>>> import pandas as pd
>>> from pandas.core.algorithms import duplicated
>>> s=pd.Series([1,2,3,4,2,3,1])
>>> duplicated(s)
array([False, False, False, False,  True,  True,  True])

So the input type should be updated.
@Dr-Irv Dr-Irv added Bug Needs Triage Issue that has not been reviewed by a pandas team member Typing type annotations, mypy/pyright type checking and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jul 19, 2021
@Dr-Irv Dr-Irv mentioned this issue Jul 19, 2021
Merged
4 tasks
@lilisako lilisako mentioned this issue Jul 22, 2021
Closed
4 tasks
@mroeschke mroeschke added the duplicated duplicated, drop_duplicates label Aug 21, 2021
@simonjayhawkins simonjayhawkins added this to the Contributions Welcome milestone Jun 11, 2022
@mroeschke mroeschke removed this from the Contributions Welcome milestone Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicated duplicated, drop_duplicates Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TYP: Update input of core.algorithms.duplicated
3 participants
@mroeschke @simonjayhawkins @Dr-Irv