Skip to content

CI/TYP: remove unneeded stata ignore #42614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

mzeitlin11
Copy link
Member

Should fix typing failure on master

@mzeitlin11 mzeitlin11 added CI Continuous Integration IO Stata read_stata, to_stata Typing type annotations, mypy/pyright type checking labels Jul 19, 2021
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is dependent on #42612 (comment)

environment.yml is the env used for mypy type checking on ci. so if pinned this PR is not needed?

@simonjayhawkins
Copy link
Member

environment.yml is the env used for mypy type checking on ci. so if pinned this PR is not needed?

oh numpy has bumped as well as fastparquet on ci. so not related.

@simonjayhawkins
Copy link
Member

oh numpy has bumped

I assume this will happen on 1.3.x too, so milestone 1.3.1 to trigger backport

@simonjayhawkins simonjayhawkins added this to the 1.3.1 milestone Jul 19, 2021
@simonjayhawkins simonjayhawkins merged commit fa8ccbf into pandas-dev:master Jul 19, 2021
@simonjayhawkins
Copy link
Member

Thanks @mzeitlin11

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jul 19, 2021
@simonjayhawkins simonjayhawkins mentioned this pull request Jul 19, 2021
2 tasks
sthagen added a commit to sthagen/pandas-dev-pandas that referenced this pull request Jul 19, 2021
CI/TYP: remove unneeded stata ignore (pandas-dev#42614)
@mzeitlin11 mzeitlin11 deleted the typ_ignore branch July 19, 2021 21:10
jreback pushed a commit that referenced this pull request Jul 19, 2021
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration IO Stata read_stata, to_stata Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants