Skip to content

Pin fastparquet #42612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 20, 2021
Merged

Pin fastparquet #42612

merged 13 commits into from
Jul 20, 2021

Conversation

lithomas1
Copy link
Member

@lithomas1 lithomas1 commented Jul 19, 2021 •
edited by simonjayhawkins
Loading

Get CI to green.

@bashtage
Copy link
Contributor

Should probably pin in requirements-dev.txt as well until it is ready to move to 0.7.0.

@simonjayhawkins simonjayhawkins added this to the 1.3.1 milestone Jul 19, 2021
@simonjayhawkins
Copy link
Member

The fastparquet tests also fail on 1.3.x, so milestone 1.3.1 to trigger backport

@simonjayhawkins simonjayhawkins added CI Continuous Integration IO Parquet parquet, feather labels Jul 19, 2021
@simonjayhawkins
Copy link
Member

@lithomas1 can you open an issue to unpin this.

simonjayhawkins
simonjayhawkins requested changes Jul 19, 2021
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit failure.

@simonjayhawkins
Copy link
Member

@lithomas1 can you open an issue to unpin this.

added xref to the issue to the op, so no need to open a separate issue.

jreback
jreback reviewed Jul 20, 2021
View reviewed changes
ci/deps/actions-38-db.yaml
@@ -15,7 +15,7 @@ dependencies:
- beautifulsoup4
- botocore>=1.11
- dask
- fastparquet>=0.4.0
- fastparquet>=0.4.0, < 0.7.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this causes a pre-commit failure (remove the space before the 0.7.0)

@lithomas1
Copy link
Member Author

@github-actions pre-commit

@lithomas1
Copy link
Member Author

lithomas1 commented Jul 20, 2021 •
edited
Loading

Green, can someone from @pandas-dev/pandas-core merge?

Sorry about the noise in this PR, was using the Github Web UI, which pre-commit apparently doesn't like.

Windows py39 is unrelated timeout. Windows py38 & Database are the only builds that matter in this case.

@phofl phofl merged commit 46ed60a into pandas-dev:master Jul 20, 2021
@lumberbot-app
Copy link

lumberbot-app bot commented Jul 20, 2021

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.3.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 46ed60a2cb007276b38f0bcdead312d95cfc4d54
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #42612: Pin fastparquet'
  1. Push to a named branch :
git push YOURFORK 1.3.x:auto-backport-of-pr-42612-on-1.3.x
  1. Create a PR against branch 1.3.x, I would have named this PR:

"Backport PR #42612 on branch 1.3.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

sthagen added a commit to sthagen/pandas-dev-pandas that referenced this pull request Jul 20, 2021
@sthagen
Merge pull request #229 from pandas-dev/master
7f5489e 
Pin fastparquet (pandas-dev#42612)
@phofl
Copy link
Member

phofl commented Jul 20, 2021

thx @lithomas1

@lithomas1 lithomas1 deleted the patch-2 branch July 20, 2021 17:07
phofl pushed a commit to phofl/pandas that referenced this pull request Jul 20, 2021
@lithomas1 @phofl
Backport PR pandas-dev#42612: Pin fastparquet
26cd9b7
@phofl
Copy link
Member

phofl commented Jul 20, 2021

backported manually

@lithomas1
Copy link
Member Author

thx @phofl.

@simonjayhawkins simonjayhawkins mentioned this pull request Jul 20, 2021
Merged
simonjayhawkins pushed a commit that referenced this pull request Jul 20, 2021
@phofl @lithomas1
Backport PR #42612: Pin fastparquet (#42632)
c69eb29 
Co-authored-by: Thomas Li <[email protected]>
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@lithomas1 @feefladder
Pin fastparquet (pandas-dev#42612)
903196d 
* Update sdist.yml

* Update pre-commit.yml

* Update posix.yml

* Pin fastparquet

* Pin more fastparquet

* Pin in environment.yml

* Pin in requirements-dev

* Update requirements-dev.txt

* Update requirements-dev.txt

* Update requirements-dev.txt

* Actually fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

@simonjayhawkins simonjayhawkins simonjayhawkins requested changes

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration IO Parquet parquet, feather
Projects
None yet
Milestone
1.3.1
Development

Successfully merging this pull request may close these issues.
5 participants
@lithomas1 @bashtage @simonjayhawkins @phofl @jreback