Skip to content

TYP: clean for PY3.8 (TypedDict) #42607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2021
Merged

TYP: clean for PY3.8 (TypedDict) #42607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd74d56
TYP: clean for PY3.8 (TypedDict)
simonjayhawkins Jul 19, 2021
4fb8e37
Merge remote-tracking branch 'upstream/master' into typing-38-3
simonjayhawkins Jul 19, 2021
102b918
Merge remote-tracking branch 'upstream/master' into typing-38-3
simonjayhawkins Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions pandas/_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@
# and use a string literal forward reference to it in subsequent types
# https://mypy.readthedocs.io/en/latest/common_issues.html#import-cycles
if TYPE_CHECKING:
from typing import TypedDict

import numpy.typing as npt

from pandas._libs import (
Expand Down Expand Up @@ -73,8 +71,6 @@
from pandas.tseries.offsets import DateOffset
else:
npt: Any = None
# typing.TypedDict does not exist until py38
TypedDict = dict


# array-like
Expand Down
2 changes: 1 addition & 1 deletion pandas/io/formats/style_render.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
Optional,
Sequence,
Tuple,
TypedDict,
Union,
)
from uuid import uuid4
Expand All @@ -21,7 +22,6 @@
from pandas._config import get_option

from pandas._libs import lib
from pandas._typing import TypedDict
from pandas.compat._optional import import_optional_dependency

from pandas.core.dtypes.generic import ABCSeries
Expand Down