Skip to content

TYP: clean for PY3.8 (TypedDict) #42607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2021

Conversation

simonjayhawkins
Copy link
Member

No description provided.

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Jul 19, 2021
@simonjayhawkins simonjayhawkins added this to the 1.4 milestone Jul 19, 2021
@jbrockmendel
Copy link
Member

looks like there's a now-unnecessary "type: ignore"

@simonjayhawkins
Copy link
Member Author

looks like there's a now-unnecessary "type: ignore"

that's not just this PR. needs a separate PR to fix.

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcoGorelli MarcoGorelli merged commit 28ff1e8 into pandas-dev:master Jul 21, 2021
sthagen added a commit to sthagen/pandas-dev-pandas that referenced this pull request Jul 21, 2021
@simonjayhawkins simonjayhawkins deleted the typing-38-3 branch July 21, 2021 13:12
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants