STYLE: moving spacing conventions in cython casting to pre-commit

[01-vyom]

• closes STYLE move spacing conventions in cython casting to pre-commit #42121
• tests added / passed
• Ensure all linting tests pass, see here for how to run them
• whatsnew entry

[github-actions]

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

[01-vyom]

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

Working

[MarcoGorelli]

are you sure? looks like there's still lot's of failures https://github.com/pandas-dev/pandas/pull/42186/checks?check_run_id=3164816180

[01-vyom]

Sorry for the late reply, I think it's because the check is working on .rst files as well according to the include statement in the .yaml file:

pandas/.pre-commit-config.yaml

Lines 96 to 108 in 2f49b8d

	entry: |
	(?x)
	# outdated annotation syntax, missing error codes
	\#\ type:\ (?!ignore)
	|\#\ type:\s?ignore(?!\[)
	# Incorrect code-block / IPython directives
	|\.\.\ code-block\ ::
	|\.\.\ ipython\ ::
	# Cython casting is of the form `<type>obj` as opposed to `<type> obj`
	|[a-zA-Z0-9*]>\s
	types_or: [python, cython, rst]

What should we do? separate this check with another id for only cython files?

[MarcoGorelli]

Ah yes, you're right. Then yes, just make another hook and only run it on .pyx and .pxi.in files in pandas/_libs

[MarcoGorelli]

[MarcoGorelli]

sorry, forgot this last time, we should also remove 'lint' from this file (there's a few places where it crops up)

pandas/ci/code_checks.sh

Line 13 in 4f0e2e9

# $ ./ci/code_checks.sh lint # run linting only

[01-vyom]

sorry, forgot this last time, we should also remove 'lint' from this file (there's a few places where it crops up)

pandas/ci/code_checks.sh

Line 13 in 4f0e2e9

# $ ./ci/code_checks.sh lint # run linting only

Made the changes, should be good to go

[MarcoGorelli]

oops, CI checks are failing, there's still

pandas/.github/workflows/ci.yml

Lines 51 to 53 in 4f0e2e9

	- name: Linting
	run: ci/code_checks.sh lint
	if: always()

(after that, should be good to go!)

[01-vyom]

Need to make changes in docs as well.

[01-vyom]

There are also docs for pattern matching, but it has been moved so should I change it as well?

Doc1

Doc2:

pandas/ci/code_checks.sh

Lines 5 to 9 in 4f0e2e9

	# This script is intended for both the CI and to check locally that code standards are
	# respected. We are currently linting (PEP-8 and similar), looking for patterns of
	# common mistakes (sphinx directives with missing blank lines, old style classes,
	# unwanted imports...), we run doctests here (currently some files only), and we
	# validate formatting error in docstrings.

[MarcoGorelli]

Thanks for spotting that - yeah, sure!

[MarcoGorelli]