Skip to content

PERF: Use list comprehension to join strings (#41753) #42173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from Jul 11, 2021
Merged

PERF: Use list comprehension to join strings (#41753) #42173

merged 6 commits into from Jul 11, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 21, 2021

PERF: Use list comprehension to join strings (#41753)

@jreback jreback added the Performance Memory or execution speed performance label Jun 22, 2021
@jreback jreback added this to the 1.3 milestone Jun 22, 2021
@MarcoGorelli
Copy link
Member

Thanks @vrserpa - if you fetch and merge upstream/master that should fix the pre-commit failure

Are you interested in writing a linting check for this in pandas-dev-flaker?

@ghost
Copy link
Author

ghost commented Jun 22, 2021

Hi @MarcoGorelli, I will write a linting check for pandas-dev-flaker.

@MarcoGorelli
Copy link
Member

awesome, thanks, let me know if you want/need any help with that - I expect you'd be able to model it off of https://github.com/asottile/pyupgrade/blob/5fb168667ae73f157dd579344708e1cdfb0c0341/pyupgrade/_plugins/generator_expressions_pep289.py

@ghost
Copy link
Author

ghost commented Jun 22, 2021

Thanks @MarcoGorelli! I'm going to have a look at this.

@jreback jreback removed this from the 1.3 milestone Jun 24, 2021
@ghost ghost mentioned this pull request Jul 1, 2021
Merged
@MarcoGorelli
Copy link
Member

Hi @vrserpa - can you fetch and merge upstream/master?

@ghost
Copy link
Author

ghost commented Jul 11, 2021

Ok!

@MarcoGorelli
Copy link
Member

can you fixup the pre-commit failures please? https://pandas.pydata.org/docs/development/contributing_codebase.html#pre-commit

@ghost
Copy link
Author

ghost commented Jul 11, 2021

Sorry, @MarcoGorelli. I did the check with pre-commit now.

MarcoGorelli
MarcoGorelli approved these changes Jul 11, 2021
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me pending green

@mroeschke
Copy link
Member

@MarcoGorelli will this be automatically checked in the CI/precommit?

@MarcoGorelli
Copy link
Member

once pandas-dev/pandas-dev-flaker#26 is in, yup!

@MarcoGorelli MarcoGorelli added this to the 1.4 milestone Jul 11, 2021
@MarcoGorelli MarcoGorelli merged commit 42adb9f into pandas-dev:master Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Performance Memory or execution speed performance
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcoGorelli @mroeschke @jreback