Linting check of use of string join() with generator expression #26
Conversation
|
Hey @vrserpa - thanks for doing this! Somehow I didn't get a notification (looks like I'd accidentally unwatched this repo), so sorry for the delay I'll take a look at the weekend |
|
Hi, @MarcoGorelli! |
|
Ok! |
|
Hi, @MarcoGorelli! |
Codecov Report
@@ Coverage Diff @@
## main #26 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 49 51 +2
Lines 659 685 +26
Branches 84 86 +2
=========================================
+ Hits 659 685 +26
Continue to review full report at Codecov.
|
pandas_dev_flaker/_ast_helpers.py
Outdated
| python_version = float(sys.version_info.major) + 0.1 * float( | ||
| sys.version_info.minor, | ||
| ) |
There was a problem hiding this comment.
😄 never do this, just use sys.version_info
There was a problem hiding this comment.
besides, ask yourself what would happen for Python 3.10...
pandas_dev_flaker/_ast_helpers.py
Outdated
| (python_version < 3.8 and isinstance(node.func.value, ast.Str)) | ||
| or ( | ||
| python_version >= 3.8 | ||
| and isinstance(node.func.value, ast.Constant) | ||
| and isinstance(node.func.value.value, str) | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Does it not work to just use
isinstance(node.func.value, ast.Str)
in all versions of Python?
There was a problem hiding this comment.
ast.Str is deprecated since python 3.8. It will be removed in future python releases, according to ast.
There was a problem hiding this comment.
ah, I wasn't aware, thanks!
pandas_dev_flaker/_ast_helpers.py
Outdated
| ) -> bool: | ||
| return isinstance(node.func, ast.Attribute) and ( | ||
| ( | ||
| sys.version_info[0:2] < (3, 8) |
There was a problem hiding this comment.
you can just do sys.version_info < (3, 8)
As requested in pandas #42173, a linting check of the use of string join() with generator expression is added.