BUG: nan-objects lookup fails with Python3.10 #41988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realead
changed the title
|
No significant changes in performance in the asv-bench. |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jun 17, 2021
|
thanks @realead the reason merging these to 1.3 is since 3.10 will be out before 1.4/2.0 :-> |
|
@meeseeksdev backport 1.3.x |
|
Something went wrong ... Please have a look at my logs. |
jreback
pushed a commit
that referenced
this pull request
Jun 17, 2021
…2086) Co-authored-by: realead <[email protected]>
This was referenced Jun 18, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon #41952, which should be integrated first.
We no longer can assume that the CPython's hash function for elements with NaN (float, complex, tuple) will do the right thing (see python/cpython@a07da09) and thus need to replace the default CPython's hash-function with our own, similar to the way we handle equality-operator.
We need to use old CPython hash functions for
floatandcomplex, because we would like to keep the equivalencyint(k)==float(k)==complex(k, 0.0).We have more freedom with tuple's hash-function, but still use CPython's implementation, so we get old hash-values.