Skip to content

BLD: ignore multiple types of file in wheel #41977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2021

Conversation

fangchenli
Copy link
Member

xref #40169

@jreback jreback added this to the 1.3 milestone Jun 13, 2021
@jreback jreback added the Build Library building on various platforms label Jun 13, 2021
@jreback
Copy link
Contributor

jreback commented Jun 13, 2021

lgtm

@simonjayhawkins give this a try and merge / backport if good

@jbrockmendel jbrockmendel merged commit c791592 into pandas-dev:master Jun 13, 2021
@jbrockmendel
Copy link
Member

thanks @fangchenli

@simonjayhawkins
Copy link
Member

Thanks @fangchenli

will open PR on pandas-wheels to test

@simonjayhawkins
Copy link
Member

will open PR on pandas-wheels to test

MacPython/pandas-wheels#135

@simonjayhawkins
Copy link
Member

we still need the pxi.in template files

    File "/tmp/pip-build-env-jawd5f8v/overlay/lib/python3.7/site-packages/setuptools/build_meta.py", line 135, in _get_build_requires
      self.run_setup()
    File "/tmp/pip-build-env-jawd5f8v/overlay/lib/python3.7/site-packages/setuptools/build_meta.py", line 259, in run_setup
      self).run_setup(setup_script=setup_script)
    File "/tmp/pip-build-env-jawd5f8v/overlay/lib/python3.7/site-packages/setuptools/build_meta.py", line 150, in run_setup
      exec(compile(code, __file__, 'exec'), locals())
    File "setup.py", line 650, in <module>
      ext_modules=maybe_cythonize(extensions, compiler_directives=directives),
    File "setup.py", line 422, in maybe_cythonize
      build_ext.render_templates(_pxifiles)
    File "setup.py", line 91, in render_templates
      with open(pxifile) as f:
  FileNotFoundError: [Errno 2] No such file or directory: 'pandas/_libs/algos_common_helper.pxi.in'

@simonjayhawkins
Copy link
Member

simonjayhawkins commented Jun 13, 2021

The wheels on pandas-wheels look to be building OK, these must be built from (github) source. the failure in previous comment is from https://github.com/simonjayhawkins/pandas-release/actions/runs/932775977 (built from sdist)

global-exclude *.cpp
global-exclude *.h

global-exclude *.py[codx]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this should be *.py[ocd] to match .gitignore

global-exclude *.h

global-exclude *.py[codx]
global-exclude *.px[di]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and *.pxi


global-exclude *.py[codx]
global-exclude *.px[di]
global-exclude *.pxi.in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and remove this.

will submit a PR once get pip-test and conda-test to pass locally (built from sdist) with these changes

Comment on lines +43 to +45
global-exclude *.c
global-exclude *.cpp
global-exclude *.h
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to keep the .c and .h for vendored code e.g. parsers etc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

graft pandas/_libs/src seems to work ok (and need to do the same for np_datetime.c and another couple of files)

@fangchenli fangchenli deleted the clean-wheel branch June 18, 2021 02:23
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants