-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BLD: ignore multiple types of file in wheel #41977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lgtm @simonjayhawkins give this a try and merge / backport if good |
thanks @fangchenli |
Co-authored-by: Fangchen Li <[email protected]>
Thanks @fangchenli will open PR on pandas-wheels to test |
|
we still need the pxi.in template files
|
The wheels on pandas-wheels look to be building OK, these must be built from (github) source. the failure in previous comment is from https://github.com/simonjayhawkins/pandas-release/actions/runs/932775977 (built from sdist) |
global-exclude *.cpp | ||
global-exclude *.h | ||
|
||
global-exclude *.py[codx] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this should be *.py[ocd]
to match .gitignore
global-exclude *.h | ||
|
||
global-exclude *.py[codx] | ||
global-exclude *.px[di] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and *.pxi
|
||
global-exclude *.py[codx] | ||
global-exclude *.px[di] | ||
global-exclude *.pxi.in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and remove this.
will submit a PR once get pip-test and conda-test to pass locally (built from sdist) with these changes
global-exclude *.c | ||
global-exclude *.cpp | ||
global-exclude *.h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to keep the .c and .h for vendored code e.g. parsers etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
graft pandas/_libs/src
seems to work ok (and need to do the same for np_datetime.c and another couple of files)
xref #40169