Skip to content

CI: add sdist test for PRs #39417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fangchenli opened this issue Jan 26, 2021 · 4 comments · Fixed by #41685
Closed

CI: add sdist test for PRs #39417

fangchenli opened this issue Jan 26, 2021 · 4 comments · Fixed by #41685
Labels
Build Library building on various platforms CI Continuous Integration
Milestone

Comments

@fangchenli
Copy link
Member

In #38852, we talked about adding CI job to build and test sdist. So we could discover relevant errors sooner. xref #38852 (comment)

@fangchenli fangchenli added Bug Needs Triage Issue that has not been reviewed by a pandas team member Build Library building on various platforms CI Continuous Integration and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jan 26, 2021
@fangchenli fangchenli changed the title CI: use CI to test sdist CI: add sdist test for PRs Jan 26, 2021
fangchenli added a commit to fangchenli/pandas that referenced this issue May 26, 2021
@jorisvandenbossche
Copy link
Member

Given the recent problems we had with #41977, #41981 (originally from changes in #38852), it might be good to actually add this as a workflow in our CI.

@simonjayhawkins if I understand correctly, you have a workflow for this in your fork that you use for testing the release branch (or RC) regularly? If that's the case, it might not be a lot of work for you to move that to the main repo's CI?
(otherwise, #38852 also temporarily contained such a workflow: e3b0cd2, or that might actually be the same as yours)

@jorisvandenbossche jorisvandenbossche added this to the 1.4 milestone Jun 15, 2021
@jorisvandenbossche
Copy link
Member

Whoops, I only notice now that @fangchenli already opened a PR for it: #41685

@simonjayhawkins
Copy link
Member

@simonjayhawkins if I understand correctly, you have a workflow for this in your fork that you use for testing the release branch (or RC) regularly?

yes it picked up the problems in #41977, but missed the setuptools issue (ignore that the conda-test has been failing for the last week) as setuptools was in the test container and also missed the wheel size issue.

@simonjayhawkins
Copy link
Member

The wheels still built on pandas-wheels after #41977, an alternative to a ci workflow in pandas, is to build the wheels from the sdist on pandas-wheels instead of the github source, problems would be picked up on the nightly builds, or if a last minute change, before release.

@jreback jreback modified the milestones: 1.4, 1.3 Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms CI Continuous Integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants