Skip to content

TYP/BUG: fix CI #41938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2021
Merged

TYP/BUG: fix CI #41938

merged 1 commit into from
Jun 11, 2021

Conversation

twoertwein
Copy link
Member

Fix bug introduced in #41903

Mypy doesn't seem to like generic types with default values?

@jreback jreback added this to the 1.3 milestone Jun 11, 2021
@jreback jreback added the Typing type annotations, mypy/pyright type checking label Jun 11, 2021
@jreback
Copy link
Contributor

jreback commented Jun 11, 2021

thanks @twoertwein ping on green

@twoertwein
Copy link
Member Author

@jreback green except for macOS

@jreback jreback merged commit da12db8 into pandas-dev:master Jun 11, 2021
@jreback
Copy link
Contributor

jreback commented Jun 11, 2021

thanks @twoertwein

JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants