TYP: to_csv accepts IO[bytes] and fix FilePathOrBuffer #41903
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small typing fixes:
to_csv
acceptsIO[bytes]
(replaceFilePathOrBuffer[str]
withFilePathOrBuffer[AnyStr]
)FilePathOrBuffer
because the unconstrained TypeVarpandas._typing.T
was used when the constrained TyepVartyping.AnyStr
should have been used: Could not specialize type "Buffer[AnyStr@Buffer]" Type "T@FileOrBuffer" is incompatible with constrained type variable "AnyStr"