TYP: to_numpy #41751
TYP: to_numpy #41751
Conversation
jbrockmendel
commented
May 31, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
There was a problem hiding this comment.
Thanks @jbrockmendel Is this not covered by one of @Dr-Irv PRs?
| @@ -191,7 +191,7 @@ def extract_bool_array(mask: ArrayLike) -> np.ndarray: | |||
| # We could have BooleanArray, Sparse[bool], ... | |||
| # Except for BooleanArray, this is equivalent to just | |||
| # np.asarray(mask, dtype=bool) | |||
| mask = mask.to_numpy(dtype=bool, na_value=False) | |||
| mask = mask.to_numpy(dtype=np.dtype("bool"), na_value=False) | |||
There was a problem hiding this comment.
this shouldn't need to be changed. Not sure without checking when the NpDtype alias was added, but pretty sure from memory that this is causing several issues (e.g. #41203 (review)) and needs to be fixed first. #41185
There was a problem hiding this comment.
either way i guess. at some point it is going to be cast to a np.dtype object, so i see it as harmless
There was a problem hiding this comment.
yes, but the change means that the to_numpy annotation is wrong and since it's public will give false positives to users.
simonjayhawkins
added
ExtensionArray
I haven't done |
|
if this is handled elsewhere we can just close it |
