-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TYP: use DTypeLike alias from numpy.typing #41185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dtype = Union[ | ||
"ExtensionDtype", NpDtype, type_t[Union[str, float, int, complex, bool, object]] | ||
] | ||
Dtype = Union["ExtensionDtype", NpDtype] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to worry about strings like "categorical" that can be interpreted as pandas dtypes but not np.dtype?
@simonjayhawkins I hope you an approve and merge in #40421 before this one gets merged, because many of the changes there are with respect to using |
I recall suggesting doing this as a precursor. some changes in #40421 would become unnecessary as the mypy errors are false postives. |
closing to clear queue. will hopefully circle back to typing next week. |
@Dr-Irv @jbrockmendel I probably won't have time to revisit this for a while (probably after 1.3.1 to allow time to follow regressions from 1.3) so feel free to take this on. |
I could be wrong, but I think this is necessary precursor to the EA typing work. |
I think you could do it in either order. If we can merge in the things I have been working on since late January, incorporating the changes in this PR will be straightforward. On the other hand, if we merge in this PR, then I probably have to make changes in my 4 open PRs, which would be a PITA. |
No description provided.