Skip to content

TST: Check map function works with StringDtype (#40823) #41723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 2, 2021
Merged

TST: Check map function works with StringDtype (#40823) #41723

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b59d6b8
TST: Check map function works with StringDType (#40823).
mdhsieh May 29, 2021
590396d
TST: Remove unused imports.
mdhsieh May 29, 2021
c707f1b
TST: Remove new test file since want to add test in existing file.
mdhsieh Jun 1, 2021
d8347c8
TST: Add new test to pandas/tests/apply/test_series_apply.py
mdhsieh Jun 1, 2021
bf85840
TST: Add updated test on Series (#40823).
mdhsieh Jun 1, 2021
078b1b6
TST: Change StringDType to any string data type.
mdhsieh Jun 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions pandas/tests/frame/methods/test_map.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import pandas as pd
import pandas._testing as tm


class TestMap:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have extensive map tests here: pandas/tests/apply/test_series_apply.py

see if you can find something similar. you can use the fixture any_string_dtype to parmeterize this over various kinds of strings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok moved. Should the fixture be used like this?

# parameter
test_series_map_stringdtype(any_string_dtype):
    ser1 = Series(
        # ...
        # then set here for all Series
        dtype=any_string_dtype,
    )

def test_map(self):
# map test on StringDType, GH#40823
df1 = pd.DataFrame(
{"col1": [pd.NA, "foo", "bar"]},
index=["id1", "id2", "id3"],
dtype=pd.StringDtype(),
)

df2 = pd.DataFrame({"id": ["id4", "id2", "id1"]}, dtype=pd.StringDtype())

df2["col1"] = df2["id"].map(df1["col1"])

result = df2
expected = pd.DataFrame(
{"id": ["id4", "id2", "id1"], "col1": [pd.NA, "foo", pd.NA]},
dtype=pd.StringDtype(),
)

tm.assert_frame_equal(result, expected)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a series method, so test on that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, updated the test.