TST: Check map function works with StringDtype (#40823) #41723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
May 31, 2021
| import pandas._testing as tm | ||
|
|
||
|
|
||
| class TestMap: |
There was a problem hiding this comment.
we have extensive map tests here: pandas/tests/apply/test_series_apply.py
see if you can find something similar. you can use the fixture any_string_dtype to parmeterize this over various kinds of strings.
There was a problem hiding this comment.
Ok moved. Should the fixture be used like this?
# parameter
test_series_map_stringdtype(any_string_dtype):
ser1 = Series(
# ...
# then set here for all Series
dtype=any_string_dtype,
)
| dtype=pd.StringDtype(), | ||
| ) | ||
|
|
||
| tm.assert_frame_equal(result, expected) |
There was a problem hiding this comment.
this is a series method, so test on that.
There was a problem hiding this comment.
Sure, updated the test.
jreback
added
Strings
Checking map function on two series of data type StringDType. Series data is arbitrary.
Using suggested test fixture any_string_dtype.
jreback
approved these changes
Jun 2, 2021
|
thanks @mdhsieh |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks map function output on 2 DataFrames with data type StringDtype.