Skip to content

[ArrowStringArray] TST/CLN: cleanup str.replace tests #41600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2021
Merged

[ArrowStringArray] TST/CLN: cleanup str.replace tests #41600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d74fd16
[ArrowStringArray] TST/CLN: cleanup str.replace tests
simonjayhawkins May 21, 2021
68b3a59
parametrize test_replace_regex_single_character
simonjayhawkins May 21, 2021
67bffb2
fixup
simonjayhawkins May 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/core/strings/accessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1348,7 +1348,7 @@ def replace(self, pat, repl, n=-1, case=None, flags=0, regex=None):
)
if len(pat) == 1:
msg += (
" In addition, single character regular expressions will"
" In addition, single character regular expressions will "
"*not* be treated as literal strings when regex=True."
)
warnings.warn(msg, FutureWarning, stacklevel=3)
Expand Down
11 changes: 0 additions & 11 deletions pandas/tests/series/methods/test_replace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,14 +449,3 @@ def test_replace_with_compiled_regex(self):
result = s.replace({regex: "z"}, regex=True)
expected = pd.Series(["z", "b", "c"])
tm.assert_series_equal(result, expected)

@pytest.mark.parametrize("pattern", ["^.$", "."])
def test_str_replace_regex_default_raises_warning(self, pattern):
# https://github.com/pandas-dev/pandas/pull/24809
s = pd.Series(["a", "b", "c"])
msg = r"The default value of regex will change from True to False"
if len(pattern) == 1:
msg += r".*single character regular expressions.*not.*literal strings"
with tm.assert_produces_warning(FutureWarning) as w:
s.str.replace(pattern, "")
assert re.match(msg, str(w[0].message))
Loading