[ArrowStringArray] TST/CLN: cleanup str.replace tests #41600
Conversation
simonjayhawkins
added
Testing
| tm.assert_series_equal(result, expected) | ||
|
|
||
|
|
||
| def test_replace_regex_default_warning(any_string_dtype): |
There was a problem hiding this comment.
this one from pandas/tests/series/methods/test_replace.py and split and tested result
| tm.assert_series_equal(result, expected) | ||
|
|
||
|
|
||
| def test_replace_regex_default_warning_single_character(any_string_dtype): |
There was a problem hiding this comment.
split since we don't have testing for the default behavior treating a single character as a literal
| @@ -148,6 +152,81 @@ def test_contains_na_kwarg_for_nullable_string_dtype( | |||
| tm.assert_series_equal(result, expected) | |||
|
|
|||
|
|
|||
| def test_contains_moar(any_string_dtype): | |||
There was a problem hiding this comment.
moved from later in the file, collocated with other str.contains tests
| ser.str.replace(pat, "", regex=False) | ||
|
|
||
|
|
||
| def test_replace_moar(any_string_dtype): |
There was a problem hiding this comment.
moved from later in the file, collocated with other str.replace tests
| tm.assert_series_equal(result, expected) | ||
|
|
||
| expected = Series(["foo__barBAD", np.nan], dtype=any_string_dtype) | ||
| result = ser.str.replace("BAD", "", n=1, regex=False) |
There was a problem hiding this comment.
no coverage for n with regex=False
|
Hello @simonjayhawkins! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-05-21 10:53:20 UTC |
| # https://github.com/pandas-dev/pandas/pull/24809 | ||
|
|
||
| # The current behavior is to treat single character patterns as literal strings, | ||
| # even when ``regex`` is set to ``True``. |
There was a problem hiding this comment.
add commit to parametrize this test.
| [False, False, False, True, False, False, np.nan, False, False, False], | ||
| dtype=expected_dtype, | ||
| ) | ||
| tm.assert_series_equal(result, expected) |
There was a problem hiding this comment.
could parmaeterize at some point
There was a problem hiding this comment.
sure. not doing too many changes in one pass to keep the diff simpler
pre-cursor to #41590