Skip to content

[ArrowStringArray] REF: str.extract - move code from function to accessor method #41541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented May 18, 2021

perf neutral refactor

draft as conflict with #41539

@simonjayhawkins simonjayhawkins added Refactor Internal refactoring of code Strings String extension data type and string data labels May 18, 2021
@simonjayhawkins simonjayhawkins marked this pull request as ready for review May 18, 2021 18:33
@simonjayhawkins simonjayhawkins added this to the 1.3 milestone May 18, 2021
@jreback
Copy link
Contributor

jreback commented May 21, 2021

can you rebase

@jreback jreback merged commit 6437029 into pandas-dev:master May 25, 2021
@simonjayhawkins simonjayhawkins deleted the move-code-into-accessor-method branch May 25, 2021 14:37
TLouf pushed a commit to TLouf/pandas that referenced this pull request Jun 1, 2021
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants