Skip to content

[ArrowStringArray] REF: str.extract - precusor to move from accessor to array #41539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2021

Conversation

simonjayhawkins
Copy link
Member

perf neutral refactor

combine _str_extract_expand, _str_extract_noexpand and _groups_or_na_fun into a single function _str_extract ready to move to array method.

@simonjayhawkins simonjayhawkins added Refactor Internal refactoring of code Strings String extension data type and string data labels May 18, 2021
@simonjayhawkins simonjayhawkins added this to the 1.3 milestone May 18, 2021
@jreback jreback merged commit 2ef0292 into pandas-dev:master May 18, 2021
@jreback
Copy link
Contributor

jreback commented May 18, 2021

great

@simonjayhawkins simonjayhawkins deleted the extact-array-method branch May 18, 2021 18:22
TLouf pushed a commit to TLouf/pandas that referenced this pull request Jun 1, 2021
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants