Skip to content

REF: add internal mechanics to separate index/columns sparsification in Styler #41391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 12, 2021

Conversation

attack68
Copy link
Contributor

@attack68 attack68 commented May 9, 2021

This is not a user facing change.

It adds only the necessary code to permit separate control of index/column MultIndex sparsification. Essentially it removes the get_option("display.multi_sparse") from a low level method to a higher level method where it can be overwritten by user-args later.

partly addresses #41142

@attack68 attack68 added Styler conditional formatting using DataFrame.style Refactor Internal refactoring of code labels May 9, 2021
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm doc comments.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine. happy to merge and do typing on followups or here.

@jreback jreback added this to the 1.3 milestone May 12, 2021
@attack68
Copy link
Contributor Author

@jreback ping this is green and your requested changes made.

@jreback jreback merged commit 4ec6925 into pandas-dev:master May 12, 2021
@jreback
Copy link
Contributor

jreback commented May 12, 2021

thanks @attack68

@attack68 attack68 deleted the sparisfy_separate branch May 12, 2021 16:09
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code Styler conditional formatting using DataFrame.style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants