-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
PERF: use ndarray.take instead of algos.take #40852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ok is this WIP? |
no, this is ready |
Can you run some benchmarks to verify this time? |
Eg the one I mentioned in #40818 (comment). I didn't list the exact impacted benchmarks in #40510 (comment), but eg the select_dtypes ones were also affected. |
Just ran the time_frame_agg one, no change. The non-asv motivator remains
|
|
gentle ping; this should be an unambiguous perf win |
And this time https://pandas.pydata.org/speed/pandas/#/ doesn't show any regressions! |
Un-revert part of #40510 in the hopes of tracking down where the perf impact was.