-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN/PERF: remove unused out kwd in take_nd #40510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lgtm. any perf benefit? |
mostly in the places where we call ndarray.take directly instead of going through algos.take |
@jbrockmendel did you run benchmarks for this change? |
i profiled with ipython, didnt run the asv suite. do you have a hypothesis for what part of this might be the culprit? |
No, I didn't check it in detail. This PR is touching several places, and it is also a variety of benchmarks that seem to be affected (reindexing, merge, groupby, ops, select_dtypes, dropna) |
@jbrockmendel were you able to look into this? |
OK i guess |
@jbrockmendel can you follow-up on this? |
And in a few places where we know allow_fill=False, just call the numpy version directly.