Skip to content

CLN/PERF: remove unused out kwd in take_nd #40510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 22, 2021

Conversation

jbrockmendel
Copy link
Member

And in a few places where we know allow_fill=False, just call the numpy version directly.

@jbrockmendel jbrockmendel added Clean Performance Memory or execution speed performance labels Mar 22, 2021
@jreback jreback added this to the 1.3 milestone Mar 22, 2021
@jreback
Copy link
Contributor

jreback commented Mar 22, 2021

lgtm. any perf benefit?

@jbrockmendel
Copy link
Member Author

any perf benefit?

mostly in the places where we call ndarray.take directly instead of going through algos.take

@jreback jreback merged commit c7c9c6b into pandas-dev:master Mar 22, 2021
@jbrockmendel jbrockmendel deleted the perf-take_nd-out branch March 22, 2021 14:38
@jorisvandenbossche
Copy link
Member

@jbrockmendel did you run benchmarks for this change?
There are lots of regressions at https://pandas.pydata.org/speed/pandas/#regressions?sort=1&dir=desc that point to this commit (although it's not always very accurate in pointing to the correct commit, so it can also be something else, but so should be checked)

@jbrockmendel
Copy link
Member Author

i profiled with ipython, didnt run the asv suite. do you have a hypothesis for what part of this might be the culprit?

@jorisvandenbossche
Copy link
Member

do you have a hypothesis for what part of this might be the culprit?

No, I didn't check it in detail. This PR is touching several places, and it is also a variety of benchmarks that seem to be affected (reindexing, merge, groupby, ops, select_dtypes, dropna)

@jorisvandenbossche
Copy link
Member

@jbrockmendel were you able to look into this?
(if not, I would propose to revert it for now (because that will only get harder later), and add it again in smaller parts)

@jbrockmendel
Copy link
Member Author

(if not, I would propose to revert it for now (because that will only get harder later), and add it again in smaller parts)

OK i guess

@jorisvandenbossche
Copy link
Member

@jbrockmendel can you follow-up on this?

jbrockmendel added a commit to jbrockmendel/pandas that referenced this pull request Apr 6, 2021
@jbrockmendel jbrockmendel mentioned this pull request Apr 6, 2021
jreback pushed a commit that referenced this pull request Apr 7, 2021
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants