CI, STYLE sync flake8 versions #40783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
added
CI
MarcoGorelli
force-pushed
the
sync-flake8-version
branch
from
2de4aa9 to
c2560c7
Compare
jreback
reviewed
Apr 7, 2021
| @@ -20,7 +20,7 @@ dependencies: | |||
| # code checks | |||
| - black=20.8b1 | |||
| - cpplint | |||
| - flake8 | |||
| - flake8=3.9.0 | |||
There was a problem hiding this comment.
can we have 1 build where this is unpinned?
There was a problem hiding this comment.
Sure, but there's the risk that there's be another annoying CI failure like #40457
If there's a new flake8 release, this'll get bumped up anyway by the weekly autoupdate job
|
can you merge master and merge on green. |
|
thanks @MarcoGorelli |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
* sync flake8 versions * noop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's been a couple of recent CI failures due to differences in flake8 versions: #40481, #40457
CI failures due to style checks are really annoying, so I think it's worth adding a check to ensure they're in-sync. There's already a hook with
pyyamlas additional dependency, so that environment will be reused for this check.