Skip to content

Backport PR #40471: compat: sqlalchemy deprecations #40481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2021
Merged

Backport PR #40471: compat: sqlalchemy deprecations #40481

merged 1 commit into from
Mar 17, 2021

Conversation

simonjayhawkins
Copy link
Member

Backport PR #40471

@simonjayhawkins simonjayhawkins added IO SQL to_sql, read_sql, read_sql_query Dependencies Required and optional dependencies labels Mar 17, 2021
@simonjayhawkins simonjayhawkins added this to the 1.2.4 milestone Mar 17, 2021
@simonjayhawkins
Copy link
Member Author

I'll merge this for now pending further investigation, the pre-commit checks passed locally before pushing this PR.

In general we don't do style backports, so we maybe need to pin versions for pre-commit on 1.2.x cc @MarcoGorelli

@simonjayhawkins simonjayhawkins merged commit 0c1c8c8 into pandas-dev:1.2.x Mar 17, 2021
@simonjayhawkins simonjayhawkins deleted the backport-of-pr-40471-on-1.2.x branch March 17, 2021 13:09
@simonjayhawkins
Copy link
Member Author

In general we don't do style backports, so we maybe need to pin versions for pre-commit on 1.2.x cc @MarcoGorelli

@MarcoGorelli I can now replicate locally after doing a pre-commit clean. Strange that yesqa is now failing when that has a pinned version.

I'll just open a PR directly against 1.2.x with the trivial changes required rather than investigating this further.

@simonjayhawkins
Copy link
Member Author

I'll just open a PR directly against 1.2.x with the trivial changes required rather than investigating this further.

urgh. not straightforward. flake8 fails if apply the yesqa changes.

@simonjayhawkins
Copy link
Member Author

looks like adding additional_dependencies: [flake8==3.8.4] may fix it.

@simonjayhawkins simonjayhawkins mentioned this pull request Mar 25, 2021
Merged
@MarcoGorelli MarcoGorelli mentioned this pull request Apr 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Dependencies Required and optional dependencies IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Milestone
1.2.4
Development

Successfully merging this pull request may close these issues.
2 participants
@simonjayhawkins @jbrockmendel