CLN: docstring cleanup #40713
Merged
CLN: docstring cleanup #40713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
approved these changes
Apr 1, 2021
| @@ -2412,7 +2412,7 @@ def isna(self) -> np.ndarray: | |||
|
|
|||
| Returns | |||
| ------- | |||
| numpy.ndarray | |||
| numpy.ndarray[bool] | |||
There was a problem hiding this comment.
completely minor but i think inconsistent as use of numpy.ndarray vs np.darray (see this much more) vs ndarray
There was a problem hiding this comment.
i think you're right, decided against trying to make these uniform in this PR
There was a problem hiding this comment.
yep next one (and prob should have a rule for this). note that I am saying it out loud but not knowing how hard that is :->
vladu
pushed a commit
to vladu/pandas
that referenced
this pull request
Apr 5, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.