Skip to content

DOC: Update CSS alignment for main documentation page #40650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

DOC: Update CSS alignment for main documentation page #40650

wants to merge 1 commit into from

Conversation

dsaxton
Copy link
Member

@dsaxton dsaxton commented Mar 26, 2021

Updates some CSS to better align buttons on the main documentation page. Seems to be an improvement when built locally (I'm using Ubuntu Firefox) but likely worth checking on other platforms / browsers.

Before:
image

After:
image

@dsaxton dsaxton added Docs Web pandas website labels Mar 26, 2021
@@ -34,6 +34,7 @@ programming language.
<h5 class="card-title">Getting started</h5>
<p class="card-text">New to <em>pandas</em>? Check out the getting started guides. They
contain an introduction to <em>pandas'</em> main concepts and links to additional tutorials.</p>
</div>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just moving the button out one div so it can sit inside the intro-card element and align with respect to that

Copy link
Contributor

@attack68 attack68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -87,6 +87,7 @@ programming language.
<p class="card-text">Saw a typo in the documentation? Want to improve
existing functionalities? The contributing guidelines will guide
you through the process of improving pandas.</p>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why this div and img not originally indented as children of the outer div

Copy link
Member Author

@dsaxton dsaxton Mar 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️ (hard to see but that's a man shrugging 😄)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeh definitely a shrug!

@@ -51,6 +51,7 @@ programming language.
<h5 class="card-title">User guide</h5>
<p class="card-text">The user guide provides in-depth information on the
key concepts of pandas with useful background information and explanation.</p>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why this div and img not originally indented as children of the outer div, same as below.

@@ -34,6 +34,7 @@ programming language.
<h5 class="card-title">Getting started</h5>
<p class="card-text">New to <em>pandas</em>? Check out the getting started guides. They
contain an introduction to <em>pandas'</em> main concepts and links to additional tutorials.</p>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and same here..

@jorisvandenbossche
Copy link
Member

Thanks for looking into this @dsaxton!
I updated my old PR #34065, so that is an alternative for this.

@dsaxton
Copy link
Member Author

dsaxton commented Mar 28, 2021

Thanks for looking into this @dsaxton!
I updated my old PR #34065, so that is an alternative for this.

Sure, I was thinking that PR would supersede this one. I mostly put this up in case we wanted to fix the alignment issue only before deciding on whether to use the sphinx extension (we can close this if the other is merged first).

@jorisvandenbossche jorisvandenbossche removed the Web pandas website label Mar 29, 2021
@dsaxton
Copy link
Member Author

dsaxton commented Mar 29, 2021

Seems Jeff is in favor of the sphinx extension approach so closing this

@dsaxton dsaxton closed this Mar 29, 2021
@dsaxton dsaxton deleted the button-css-alignment branch March 29, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants