-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: use the sphinx-panels extension for cards instead of raw html #34065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: use the sphinx-panels extension for cards instead of raw html #34065
Conversation
@jorisvandenbossche still relevant? |
@jorisvandenbossche gentle ping |
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
@jorisvandenbossche pls update or close |
@dsaxton I updated this PR to also convert the front page cards to use sphinx-panels, and with some custom styling to keep the same look and feel, I get this: The "buttons" are using the default darker grey and sharper corners from sphinx-panels, but if we prefer the lighter gray / more rounded corners as it is now, that's easy to change as well. For reference, screenshot of the current https://pandas.pydata.org/docs/dev/: |
Nice. The stronger contrast with the dark button color does make them a bit more readable. This is subjective though so I'm curious how others feel. |
+1 on the look and not using raw html |
doc/source/getting_started/index.rst
Outdated
</p> | ||
</div> | ||
<div class="card-footer text-muted"> | ||
conda install pandas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be
conda install pandas | |
pip install pandas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, copy/paste error ;) Thanks for the catch!
This is an alternative for #32065, using the https://sphinx-panels.readthedocs.io/en/latest/ extension (which was created inspired on how we are using this in our docs, but then nicely packaged in a sphinx extension to avoid the use of raw html).