-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: groupby any/all raising on extension types #40621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
mzeitlin11
wants to merge
12
commits into
pandas-dev:master
from
mzeitlin11:bug/any_all_extension_types
Closed
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0c29b78
WIP
mzeitlin11 b21258d
BUG: groupby any/all raising on extension types
mzeitlin11 d86a81d
precommit fixup
mzeitlin11 df672da
Fix whatsnew typo
mzeitlin11 95eb5fc
Merge remote-tracking branch 'origin/master' into bug/any_all_extensi…
mzeitlin11 99ed6e3
Use elif, add series test
mzeitlin11 5d7bd1c
precommit fixup
mzeitlin11 251d386
Amend whatsnew for series groupby
mzeitlin11 f938742
Merge remote-tracking branch 'origin/master' into bug/any_all_extensi…
mzeitlin11 6d00aa6
Merge remote-tracking branch 'origin/master' into bug/any_all_extensi…
mzeitlin11 50ca764
Add skipna parameterization
mzeitlin11 9497ff1
Merge remote-tracking branch 'origin/master' into bug/any_all_extensi…
mzeitlin11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add in skipna as a parameter in these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have added skipna parameterization to
test_bool_aggs_dup_column_labels
(this was just a test moved to keep any/all tests together)For the added nullable dtype test below, problem is that
skipna=False
case doesn't currently give the correct output (#37506)