-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: implement Kleene versions of GroupBy any/all kernels for nullable dtypes #37506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Wanted to look into this and tried to understand the implementation for Keene logic in case of
works and returns
returns an empty Series. I could not find the reason, why this was not implemted for DataFrames too, when any columns there is from dtype |
I haven't gone through the whole path put I think we may want to do this in the cython method |
For GroupBy that would probably be the best. But we have to fix #37505 before doing this, because this raises for
too before even reaching the cython part. But I meant the regular Traceback:
|
Ah but "boolean" is an Extension array right? I think if we rewrite in terms of a mask that's a fix and it's preferred performance-wise. But in the meantime we can cast to numpy before passing to cython as was done for std in #37433 |
xref #37493 (comment)
The text was updated successfully, but these errors were encountered: