Skip to content

DOC: Fix minimum Python version in contributing docs #40552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 4, 2021
Merged

DOC: Fix minimum Python version in contributing docs #40552

merged 4 commits into from
Apr 4, 2021

Conversation

hasan-yaman
Copy link
Contributor

@hasan-yaman
Copy link
Contributor Author

I think the failed check also fails in the current master. So, what should I do?

@attack68
Copy link
Contributor

I think the failed check also fails in the current master. So, what should I do?

nothing. just wait. it might get approved without, or you might be asked to rebase when master goes green again (gets fixed)

@hasan-yaman
Copy link
Contributor Author

Thanks for the explanation.

@MarcoGorelli MarcoGorelli mentioned this pull request Mar 24, 2021
Merged
4 tasks
@MarcoGorelli MarcoGorelli self-requested a review March 24, 2021 21:17
@MarcoGorelli
Copy link
Member

Hi @hasan-yaman - could you fetch and merge upstream/master please?

@MarcoGorelli
Copy link
Member

Thanks @hasan-yaman for updating - let's just wait for #40130 to be in before proceeding here

@MarcoGorelli
Copy link
Member

#40130 is in - @hasan-yaman if you rebase and ping when ready this should be good to go

@hasan-yaman
Copy link
Contributor Author

@MarcoGorelli

I moved the changes to contributing_environment.rst

Thanks for your help.

MarcoGorelli
MarcoGorelli approved these changes Apr 4, 2021
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hasan-yaman , looks good to me pending green

@MarcoGorelli MarcoGorelli added this to the 1.3 milestone Apr 4, 2021
@MarcoGorelli MarcoGorelli merged commit baa8539 into pandas-dev:master Apr 4, 2021
@hasan-yaman hasan-yaman deleted the fix-minimum-python-version branch April 4, 2021 19:59
vladu pushed a commit to vladu/pandas that referenced this pull request Apr 5, 2021
@vladu
DOC: Fix minimum Python version in contributing docs (pandas-dev#40552)
1f169b9 
* DOC: Fix minimum Python version in contributing docs

* DOC: Fix minimum Python version in contributing environment docs
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@JulianWgs
DOC: Fix minimum Python version in contributing docs (pandas-dev#40552)
06b2446 
* DOC: Fix minimum Python version in contributing docs

* DOC: Fix minimum Python version in contributing environment docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

DOC: Outdated Python version in contributing docs
3 participants
@hasan-yaman @attack68 @MarcoGorelli