Skip to content

DOC: Outdated Python version in contributing docs #40485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hasan-yaman opened this issue Mar 17, 2021 · 3 comments · Fixed by #40552
Closed

DOC: Outdated Python version in contributing docs #40485

hasan-yaman opened this issue Mar 17, 2021 · 3 comments · Fixed by #40552
Assignees
Labels

Comments

@hasan-yaman
Copy link
Contributor

hasan-yaman commented Mar 17, 2021

Location of the documentation

URL of the documentation

Note: You can check the latest versions of the docs on master here.
(Problem exist in the latest version: here)

Documentation problem

In the documents, it says at least Python 3.6.1 installed to create Python virtual environment to contribute Pandas. However, to install some development requirements (such as NumPy) Python version must be >=3.7. See here for NumPy minimum requirement.

Suggested fix for documentation

We should update the relevant document so contributors can install an appropriate virtual environment for contribution.
Suggested edit:
You’ll need to have at least Python 3.7 installed on your system.

@hasan-yaman hasan-yaman added Docs Needs Triage Issue that has not been reviewed by a pandas team member labels Mar 17, 2021
@hasan-yaman
Copy link
Contributor Author

I can take the issue if the proposed solution is fine.

@lithomas1 lithomas1 removed the Needs Triage Issue that has not been reviewed by a pandas team member label Mar 17, 2021
@lithomas1 lithomas1 added this to the Contributions Welcome milestone Mar 17, 2021
@hasan-yaman
Copy link
Contributor Author

take

@rhshadrach
Copy link
Member

Thanks for the report @hasan-yaman! PR to fix is most certainly welcome. I would consider leaving the python requirement vague (e.g. something like "you need to have at least the minimum python version that pandas supports") along with a link to the minimum version page. That way we don't have to routinely update the number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants