-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
STYLE: Extending codespell to pandas/tests #40320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,7 +63,7 @@ def setup(self): | |
@pytest.fixture | ||
def datetime_series(self): | ||
# Same as usual datetime_series, but with index freq set to None, | ||
# since that doesnt round-trip, see GH#33711 | ||
# since that doesn't round-trip, see GH#33711 | ||
ser = tm.makeTimeSeries() | ||
ser.name = "ts" | ||
ser.index = ser.index._with_freq(None) | ||
|
@@ -72,7 +72,7 @@ def datetime_series(self): | |
@pytest.fixture | ||
def datetime_frame(self): | ||
# Same as usual datetime_frame, but with index freq set to None, | ||
# since that doesnt round-trip, see GH#33711 | ||
# since that doesn't round-trip, see GH#33711 | ||
df = DataFrame(tm.getTimeSeriesData()) | ||
df.index = df.index._with_freq(None) | ||
return df | ||
|
@@ -459,7 +459,7 @@ def test_frame_mixedtype_orient(self): # GH10289 | |
|
||
def test_v12_compat(self, datapath): | ||
dti = pd.date_range("2000-01-03", "2000-01-07") | ||
# freq doesnt roundtrip | ||
# freq doesn't roundtrip | ||
dti = DatetimeIndex(np.asarray(dti), freq=None) | ||
df = DataFrame( | ||
[ | ||
|
@@ -489,7 +489,7 @@ def test_v12_compat(self, datapath): | |
|
||
def test_blocks_compat_GH9037(self): | ||
index = pd.date_range("20000101", periods=10, freq="H") | ||
# freq doesnt round-trip | ||
# freq doesn't round-trip | ||
index = DatetimeIndex(list(index), freq=None) | ||
|
||
df_mixed = DataFrame( | ||
|
@@ -637,8 +637,8 @@ def test_series_non_unique_index(self): | |
tm.assert_series_equal( | ||
s, read_json(s.to_json(orient="split"), orient="split", typ="series") | ||
) | ||
unser = read_json(s.to_json(orient="records"), orient="records", typ="series") | ||
tm.assert_numpy_array_equal(s.values, unser.values) | ||
user = read_json(s.to_json(orient="records"), orient="records", typ="series") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess this was meant to stand for |
||
tm.assert_numpy_array_equal(s.values, user.values) | ||
|
||
def test_series_default_orient(self, string_series): | ||
assert string_series.to_json() == string_series.to_json(orient="index") | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -355,7 +355,7 @@ def test_escapechar(all_parsers): | |
# https://stackoverflow.com/questions/13824840/feature-request-for- | ||
# pandas-read-csv | ||
data = '''SEARCH_TERM,ACTUAL_URL | ||
"bra tv bord","http://www.ikea.com/se/sv/catalog/categories/departments/living_room/10475/?se%7cps%7cnonbranded%7cvardagsrum%7cgoogle%7ctv_bord" | ||
"bra tv board","http://www.ikea.com/se/sv/catalog/categories/departments/living_room/10475/?se%7cps%7cnonbranded%7cvardagsrum%7cgoogle%7ctv_bord" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ikea is swedish and "bra tv bord" translates as "good tv stand". :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should I ignore this word then? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. naah, this is OK IMO, let's not ignore more than what's needed, I think this was written more in jest than anything 😄 |
||
"tv p\xc3\xa5 hjul","http://www.ikea.com/se/sv/catalog/categories/departments/living_room/10475/?se%7cps%7cnonbranded%7cvardagsrum%7cgoogle%7ctv_bord" | ||
"SLAGBORD, \\"Bergslagen\\", IKEA:s 1700-tals series","http://www.ikea.com/se/sv/catalog/categories/departments/living_room/10475/?se%7cps%7cnonbranded%7cvardagsrum%7cgoogle%7ctv_bord"''' # noqa | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we exclude this, then the CI check will fail - could you keep it in, we'll update these 22 files, we'll then have another PR to update another ~20 files, and then a final PR which updates the rest and removes
exclude
from this file?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK got it.