STYLE: Extending codespell to pandas/tests #40320
Conversation
01-vyom
commented
Mar 9, 2021
•
01-vyom
commented
- xref CI/STYLE extend codespell beyond pandas/core #38802
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
|
Nice, thanks @01-vyom for doing this! This changes lots of files though, could you please split it up into smaller PRs? Maybe 3 PRs doing about 20 files each? |
|
Ok, will do that |
01-vyom
force-pushed
the
pandas-codespell-38802
branch
from
20df4c9 to
ba3a86b
Compare
.pre-commit-config.yaml
Outdated
| @@ -16,7 +16,6 @@ repos: | |||
| - id: codespell | |||
| types_or: [python, rst, markdown] | |||
| files: ^(pandas|doc)/ | |||
| exclude: ^pandas/tests/ | |||
There was a problem hiding this comment.
if we exclude this, then the CI check will fail - could you keep it in, we'll update these 22 files, we'll then have another PR to update another ~20 files, and then a final PR which updates the rest and removes exclude from this file?
pandas/tests/io/json/test_pandas.py
Outdated
| @@ -637,8 +637,8 @@ def test_series_non_unique_index(self): | |||
| tm.assert_series_equal( | |||
| s, read_json(s.to_json(orient="split"), orient="split", typ="series") | |||
| ) | |||
| unser = read_json(s.to_json(orient="records"), orient="records", typ="series") | |||
| tm.assert_numpy_array_equal(s.values, unser.values) | |||
| user = read_json(s.to_json(orient="records"), orient="records", typ="series") | |||
There was a problem hiding this comment.
I guess this was meant to stand for unserialized, perhaps rename it to that?
| @@ -355,7 +355,7 @@ def test_escapechar(all_parsers): | |||
| # https://stackoverflow.com/questions/13824840/feature-request-for- | |||
| # pandas-read-csv | |||
| data = '''SEARCH_TERM,ACTUAL_URL | |||
| "bra tv bord","http://www.ikea.com/se/sv/catalog/categories/departments/living_room/10475/?se%7cps%7cnonbranded%7cvardagsrum%7cgoogle%7ctv_bord" | |||
| "bra tv board","http://www.ikea.com/se/sv/catalog/categories/departments/living_room/10475/?se%7cps%7cnonbranded%7cvardagsrum%7cgoogle%7ctv_bord" | |||
There was a problem hiding this comment.
ikea is swedish and "bra tv bord" translates as "good tv stand". :)
There was a problem hiding this comment.
Should I ignore this word then?
There was a problem hiding this comment.
naah, this is OK IMO, let's not ignore more than what's needed, I think this was written more in jest than anything 😄
|
Made all the necessary changes. |
|
I made the second PR with other files, as both of these PRs are merged I will make the final PR. |
|
Nice, thanks! There's some (unrelated to this PR) issue with CI though, will revisit once that's fixed |
|
Hi @01-vyom can you fetch and merge upstream/master please? |
…ndas-codespell-38802
|
Thanks @01-vyom ! |
