-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
[ArrayManager] Add SingleArrayManager to back a Series #40152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
69cf7bb
758df4a
2c62473
50fe6e0
8747d25
dd2511a
0412e36
805c866
e7e0cad
c3c00f4
022da5a
ffcbf37
4d8a029
606f467
26186a3
0f4bf41
2b2fa84
22295e0
3e13fed
44bd1f4
26648c7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -98,3 +98,7 @@ def equals(self, other: object) -> bool: | |
return False | ||
|
||
return self._equal_values(other) | ||
|
||
|
||
class SingleManager(DataManager): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I initially added this class to have a common subclass for SingleBlockManager and SingleArrayManager. But in the end, the only way that it is actually being used are a few places that do |
||
ndim = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally shouldn't reach into the mgr here (followon)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I am planning to do some PRs to move some of the block-custom logic from indexing.py to the internals (but it's quite complex code ..)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ive been looking at this for a while; it (at least my preferred approach) is blocked by #39510 and #39163