-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
[ArrayManager] Add SingleArrayManager to back a Series #40152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
69cf7bb
[ArrayManager] Add SingleArrayManager to back a Series
jorisvandenbossche 758df4a
fix fast_xs
jorisvandenbossche 2c62473
fix astype tests
jorisvandenbossche 50fe6e0
add SingleArrayManager.set_values - fix apply
jorisvandenbossche 8747d25
Merge remote-tracking branch 'upstream/master' into am-series
jorisvandenbossche dd2511a
use slice to avoid copy
jorisvandenbossche 0412e36
Merge remote-tracking branch 'upstream/master' into am-series
jorisvandenbossche 805c866
Merge remote-tracking branch 'upstream/master' into am-series
jorisvandenbossche e7e0cad
avoid PandasDtype in construction
jorisvandenbossche c3c00f4
fix groupby
jorisvandenbossche 022da5a
fix cumulative ops
jorisvandenbossche ffcbf37
fix putmask
jorisvandenbossche 4d8a029
rename SingleManager -> SingleDataManager, add typing union alias
jorisvandenbossche 606f467
move logic from Series.array into manager
jorisvandenbossche 26186a3
fixup return
jorisvandenbossche 0f4bf41
correct check for PandasArray
jorisvandenbossche 2b2fa84
fix typing
jorisvandenbossche 22295e0
Merge remote-tracking branch 'upstream/master' into am-series
jorisvandenbossche 3e13fed
Merge remote-tracking branch 'upstream/master' into am-series
jorisvandenbossche 44bd1f4
Merge remote-tracking branch 'upstream/master' into am-series
jorisvandenbossche 26648c7
simplify py fallback function
jorisvandenbossche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally shouldn't reach into the mgr here (followon)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I am planning to do some PRs to move some of the block-custom logic from indexing.py to the internals (but it's quite complex code ..)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ive been looking at this for a while; it (at least my preferred approach) is blocked by #39510 and #39163