-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
PERF: is_list_like #39852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
PERF: is_list_like #39852
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
10f1bde
PERF: is_list_like
jbrockmendel b8856be
typo fixup
jbrockmendel 60e1008
isort fixup
jbrockmendel dda6588
isort fixup
jbrockmendel caddcfe
typo fixup
jbrockmendel 84b8dea
Merge branch 'master' into perf-block-init
jbrockmendel c00dc11
dummy commit to force hook
jbrockmendel fec9c1b
dummy commit to force hook
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
""" | ||
Benchmarks for code in pandas/_libs, excluding pandas/_libs/tslibs, | ||
which has its own directory | ||
""" | ||
import numpy as np | ||
|
||
from pandas._libs.lib import ( | ||
is_list_like, | ||
is_scalar, | ||
) | ||
|
||
from pandas import ( | ||
NA, | ||
NaT, | ||
) | ||
|
||
# TODO: share with something in pd._testing? | ||
scalars = [ | ||
0, | ||
1.0, | ||
1 + 2j, | ||
True, | ||
"foo", | ||
b"bar", | ||
None, | ||
np.datetime64(123, "ns"), | ||
np.timedelta64(123, "ns"), | ||
NaT, | ||
NA, | ||
] | ||
zero_dims = [np.array("123")] | ||
listlikes = [np.array([1, 2, 3]), {0: 1}, {1, 2, 3}, [1, 2, 3], (1, 2, 3)] | ||
|
||
|
||
class ScalarListLike: | ||
params = scalars + zero_dims + listlikes | ||
|
||
def time_is_list_like(self, param): | ||
is_list_like(param) | ||
|
||
def time_is_scalar(self, param): | ||
is_scalar(param) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarcoGorelli when the pre-commit hook runs locally, it resets these to single-line imports, which then fails the CI check. thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbrockmendel have you already merged the latest upstream changes? If not, it might be because your
setup.cfg
file didn't haveforce_grid_wrap=True
yet?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that did it, thanks