-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
PERF: is_list_like #39852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PERF: is_list_like #39852
Conversation
jbrockmendel
commented
Feb 16, 2021
nice! ping on green-ish. |
from pandas import ( | ||
NA, | ||
NaT, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarcoGorelli when the pre-commit hook runs locally, it resets these to single-line imports, which then fails the CI check. thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbrockmendel have you already merged the latest upstream changes? If not, it might be because your setup.cfg
file didn't have force_grid_wrap=True
yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that did it, thanks
ping |
nice! |
is_list_like() used to use isinstance(obj, abc.Iterable) before pandas-dev#39852 where it was optimized for performance. This resulted in a regression where objects that explicitly declare __iter__ as None are considered "list like" but not instances of abc.Iterable.
is_list_like() used to use isinstance(obj, abc.Iterable) before pandas-dev#39852 where it was optimized for performance. This resulted in a regression where objects that explicitly declare __iter__ as None are considered "list like" but not instances of abc.Iterable.
is_list_like() used to use isinstance(obj, abc.Iterable) before pandas-dev#39852 where it was optimized for performance. This resulted in a regression where objects that explicitly declare __iter__ as None are considered "list like" but not instances of abc.Iterable.