-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Fix support for matplotlib's constrained_layout (#25261) #39394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 5 commits into
pandas-dev:master
from
mdruiter:Fix_support_for_matplotlib_s_constrained_layout_25261
Jan 28, 2021
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3cc837a
ENH: Fix support for matplotlib's constrained_layout (#25261)
mdruiter 6b680bc
ENH: Fix support for matplotlib's constrained_layout (#25261)
mdruiter add8b51
Merge branch 'master' into Fix_support_for_matplotlib_s_constrained_l…
mdruiter f759dd1
minor improvements after review
mdruiter 4bf0da2
Merge remote-tracking branch 'upstream/master' into Fix_support_for_m…
mdruiter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -227,7 +227,8 @@ def _grouped_plot_by_column( | |
|
||
byline = by[0] if len(by) == 1 else by | ||
fig.suptitle(f"Boxplot grouped by {byline}") | ||
fig.subplots_adjust(bottom=0.15, top=0.9, left=0.1, right=0.9, wspace=0.2) | ||
if not hasattr(fig, "get_constrained_layout") or not fig.get_constrained_layout(): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. make a function for this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. Hope this is what you had in mind. |
||
fig.subplots_adjust(bottom=0.15, top=0.9, left=0.1, right=0.9, wspace=0.2) | ||
|
||
return result | ||
|
||
|
@@ -434,7 +435,11 @@ def boxplot_frame_groupby( | |
) | ||
ax.set_title(pprint_thing(key)) | ||
ret.loc[key] = d | ||
fig.subplots_adjust(bottom=0.15, top=0.9, left=0.1, right=0.9, wspace=0.2) | ||
if ( | ||
not hasattr(fig, "get_constrained_layout") | ||
or not fig.get_constrained_layout() | ||
): | ||
fig.subplots_adjust(bottom=0.15, top=0.9, left=0.1, right=0.9, wspace=0.2) | ||
else: | ||
keys, frames = zip(*grouped) | ||
if grouped.axis == 0: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you be slightly more verbose here. this allows passing this option right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change just prevents pandas from doing incompatible things when a figure has constrained_layout enabled.