ENH: Fix support for matplotlib's constrained_layout (#25261) #39394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mdruiter
commented
Jan 25, 2021
•
mdruiter
commented
- closes plotting: subplots_adjust prevents use of constrained_layout=True #25261
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
|
The failing tests seem totally unrelated!? |
jreback
requested changes
Jan 25, 2021
jreback
requested changes
Jan 25, 2021
| @@ -227,7 +227,8 @@ def _grouped_plot_by_column( | |||
|
|
|||
| byline = by[0] if len(by) == 1 else by | |||
| fig.suptitle(f"Boxplot grouped by {byline}") | |||
| fig.subplots_adjust(bottom=0.15, top=0.9, left=0.1, right=0.9, wspace=0.2) | |||
| if not hasattr(fig, "get_constrained_layout") or not fig.get_constrained_layout(): | |||
There was a problem hiding this comment.
make a function for this
maybe_adjust_figure or similar
There was a problem hiding this comment.
Done. Hope this is what you had in mind.
jreback
requested changes
Jan 28, 2021
doc/source/whatsnew/v1.3.0.rst
Outdated
| @@ -341,7 +341,7 @@ Plotting | |||
| ^^^^^^^^ | |||
|
|
|||
| - Bug in :func:`scatter_matrix` raising when 2d ``ax`` argument passed (:issue:`16253`) | |||
| - | |||
| - Support matplotlib's ``constrained_layout=True`` (:issue:`25261`) | |||
There was a problem hiding this comment.
can you be slightly more verbose here. this allows passing this option right?
There was a problem hiding this comment.
The change just prevents pandas from doing incompatible things when a figure has constrained_layout enabled.
…atplotlib_s_constrained_layout_25261
jreback
approved these changes
Jan 28, 2021
|
thanks @mdruiter very nice! |
mdruiter
deleted the
Fix_support_for_matplotlib_s_constrained_layout_25261
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.