REF: Unify _set_noconvert_dtype_columns for parsers #39365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jan 25, 2021
pandas/io/parsers/base_parser.py
Outdated
| @@ -546,6 +548,65 @@ def _convert_to_ndarrays( | |||
| print(f"Filled {na_count} NA values in column {c!s}") | |||
| return result | |||
|
|
|||
| def _set_noconvert_dtype_columns(self, col_indices, names): | |||
There was a problem hiding this comment.
can you type this in any way? (esp the return value) and add a doc-string
pandas/io/parsers/base_parser.py
Outdated
| if self.usecols_dtype == "integer": | ||
| # A set of integers will be converted to a list in | ||
| # the correct order every single time. | ||
| usecols = list(self.usecols) |
There was a problem hiding this comment.
Safe-sort, because could be mixed.
There was a problem hiding this comment.
no could not, sorry. Used sorted
jreback
requested changes
Jan 26, 2021
pandas/io/parsers/base_parser.py
Outdated
|
|
||
| # pandas\io\parsers.py:2030: error: Incompatible types in | ||
| # assignment (expression has type "None", variable has type | ||
| # "List[Any]") [assignment] |
There was a problem hiding this comment.
i think if you predeclare at the top
usecols: Optional[List[Any]] = []
you can remove the ignore
There was a problem hiding this comment.
Yep, this works, typed it a bit more specific.
I've got #39342 for the mypy errors in there, will rebase when this is merged
jreback
reviewed
Jan 26, 2021
| parse_dates=[1], | ||
| usecols=[1, 2], | ||
| thousands="-", | ||
| ) |
There was a problem hiding this comment.
this is a bug yes? can you add a whatsnew note
|
@jreback green |
jreback
approved these changes
Jan 27, 2021
|
thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I unified the code which led to a bugfix. The test failed for the python parser case previously