TYP: Fix mypy ignores in parsers #39342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
can you merge master |
…p_parsers � Conflicts: � pandas/io/parsers/c_parser_wrapper.py � pandas/io/parsers/python_parser.py
|
Done @simonjayhawkins Is it ok to use the | syntax? |
|
quick comment on the |
jreback
approved these changes
Jan 29, 2021
pandas/io/parsers/base_parser.py
Outdated
| # pandas\io\parsers.py:1559: error: Need type annotation for | ||
| # 'counts' [var-annotated] | ||
| counts = defaultdict(int) # type: ignore[var-annotated] | ||
| counts: DefaultDict[int | str, int] = defaultdict(int) |
There was a problem hiding this comment.
if an mi, the dict key is a tuple?
There was a problem hiding this comment.
You are right, thx. I looked them through again and fixed 2 more I think
pandas/io/parsers/base_parser.py
Outdated
| # pandas\io\parsers.py:1559: error: Need type annotation for | ||
| # 'counts' [var-annotated] | ||
| counts = defaultdict(int) # type: ignore[var-annotated] | ||
| counts: DefaultDict[int | str, int] = defaultdict(int) |
There was a problem hiding this comment.
if an mi, the dict key is a tuple?
|
ping @simonjayhawkins |
MarcoGorelli
reviewed
Feb 3, 2021
pandas/io/parsers/base_parser.py
Outdated
Comment on lines
552
to
561
| self, col_indices: List[int], names: List[Union[int, str]] | ||
| self, col_indices: List[int], names: List[int | str | tuple] |
There was a problem hiding this comment.
see #39538 for some discussion on this syntax change - perhaps it's best to defer it?
|
thanks @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried fixing the Mypy Errors in parsers