-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Revert "CI: Skip numpy dev failing tests (#39090)" #39225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "CI: Skip numpy dev failing tests (#39090)" #39225
Conversation
This reverts commit 3bd3d1e
restarted https://github.com/pandas-dev/pandas/runs/1716733247 to confirm |
1.2.x is green, but we have different tests failing here now. Will investigate |
Could someone restart numpy dev ci? The failing tests were not touched by this revert and can not reproduce this locally. failure is always with calls like:
The second line is raising |
see that occasionally, first seen around 3rd Jan #38852 (comment) |
This seems to have spread compared to the link you've posted. We got a lot of failures in test_merge too. Was someone able to debug this? |
IIRC locally i had these failures consistently but after the next merge of master resolved. On the couple of occasions i've seen on ci, restarting ci resolved. we'll see what happens here. |
Seems to have worked here too. |
I think OK to merge this. the other test failure is also a flaky test which will pass after one or more restarts eg. restarted on #39139 and passed on second attempt.
|
Thanks @phofl |
Yeah this is an ugly one, I set up a development env on windows a few days ago but could not reproduce this. |
…dev#39225) This reverts commit 3bd3d1e
…dev#39225) This reverts commit 3bd3d1e
This reverts commit 3bd3d1e