Skip to content

Revert "CI: Skip numpy dev failing tests (#39090)" #39225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

phofl
Copy link
Member

@phofl phofl commented Jan 17, 2021

This reverts commit 3bd3d1e

@phofl phofl added CI Continuous Integration Dtype Conversions Unexpected or buggy dtype conversions labels Jan 17, 2021
@simonjayhawkins
Copy link
Member

restarted https://github.com/pandas-dev/pandas/runs/1716733247 to confirm

@simonjayhawkins simonjayhawkins added this to the 1.3 milestone Jan 17, 2021
@phofl
Copy link
Member Author

phofl commented Jan 17, 2021

1.2.x is green, but we have different tests failing here now. Will investigate

@phofl
Copy link
Member Author

phofl commented Jan 17, 2021

Could someone restart numpy dev ci? The failing tests were not touched by this revert and can not reproduce this locally.

failure is always with calls like:

df = pd.DataFrame({"A": [1, 2, 3], "B": [4, 5, 6]})
df.A

The second line is raising AttributeError: 'DataFrame' object has no attribute 'A' in this ci run

@simonjayhawkins
Copy link
Member

The second line is raising AttributeError: 'DataFrame' object has no attribute 'A' in this ci run

see that occasionally, first seen around 3rd Jan #38852 (comment)

@phofl
Copy link
Member Author

phofl commented Jan 17, 2021

This seems to have spread compared to the link you've posted. We got a lot of failures in test_merge too. Was someone able to debug this?

@simonjayhawkins
Copy link
Member

This seems to have spread compared to the link you've posted. We got a lot of failures in test_merge too. Was someone able to debug this?

IIRC locally i had these failures consistently but after the next merge of master resolved. On the couple of occasions i've seen on ci, restarting ci resolved. we'll see what happens here.

@phofl
Copy link
Member Author

phofl commented Jan 17, 2021

Seems to have worked here too.

@simonjayhawkins
Copy link
Member

simonjayhawkins commented Jan 17, 2021

I think OK to merge this. the other test failure is also a flaky test which will pass after one or more restarts eg. restarted on #39139 and passed on second attempt.

=========================== short test summary info ===========================
FAILED pandas/tests/io/pytables/test_store.py::test_coordinates - AssertionEr...
= 1 failed, 98979 passed, 4748 skipped, 1034 xfailed, 3 xpassed, 82 warnings in 1184.42s (0:19:44) =

@simonjayhawkins simonjayhawkins merged commit f0b1316 into pandas-dev:master Jan 17, 2021
@simonjayhawkins
Copy link
Member

Thanks @phofl

@phofl
Copy link
Member Author

phofl commented Jan 17, 2021

Yeah this is an ugly one, I set up a development env on windows a few days ago but could not reproduce this.

@phofl phofl deleted the revert_numpy_dev_failing_tests branch January 17, 2021 14:18
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
nofarm3 pushed a commit to nofarm3/pandas that referenced this pull request Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Numpy changed dtype inference
2 participants